[dpdk-dev] [PATCH v2] cpu_layout.py: adjust output format to align
Thomas Monjalon
thomas.monjalon at 6wind.com
Thu May 29 09:22:49 CEST 2014
Hi Shannon,
I feel this version is better but it's really complicated to read.
> +max_processor_len=len(str(len(cores)*len(sockets)*2-1))
> +max_core_map_len = max_processor_len*2+4
> +if max_core_map_len < 12:
> + max_core_map_len = 12
This line is not indented as the other ones.
> +max_core_id_len=len(str(max(cores)))
> +
> +print " ".ljust(max_core_id_len+5),
> for s in sockets:
> - print "\tSocket %s" % s,
> + print "Socket %s" % str(s).ljust(max_core_map_len-7),
> print ""
> +print " ".ljust(max_core_id_len+5),
Could you replace all these numbers by something meaningful and easier to
understand?
Example: 5 can be replaced by len('Core ')
Other comment: please add spaces around operators (= + - *).
Thanks
--
Thomas
More information about the dev
mailing list