[dpdk-dev] [PATCH v7 2/7] ixgbe:clean scattered_rx configure in dev_stop
cunming.liang at intel.com
Wed Nov 12 11:42:24 CET 2014
scatter/non-scatter always be checked during dev_start.
For others, it's only have the two. Won't do additional check during rx/tx_queue_setup(before dev_start).
So they won't have problem, I think.
But for ixgbe, it will check it meets vector condition or not, then choose the best performance function.
As the happens before dev_start, so the old value will impact the condition check.
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Wednesday, November 12, 2014 6:33 PM
> To: Liang, Cunming
> Cc: dev at dpdk.org; nhorman at tuxdriver.com; Ananyev, Konstantin; Richardson,
> Bruce; De Lara Guarch, Pablo
> Subject: Re: [PATCH v7 2/7] ixgbe:clean scattered_rx configure in dev_stop
> 2014-11-12 10:29, Liang, Cunming:
> > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > > 2014-11-12 08:21, Liang, Cunming:
> > > > For em, igb and i40e, we haven't provide so much rx/tx pair for switching.
> > >
> > > Sorry, I don't understand. Which pair are you telling about?
> > > em, igb and i40e have scattered Rx functions.
> > Maybe pair is not accurate, I means the different rx/tx register function, like:
> > ixgbe_xmit_pkts_simple/Ixgbe_xmit_pkts_vec/ixgbe_xmit_pkts
> OK that's what I understood.
> However, you should check the scatter/non-scatter Rx functions of other drivers.
> I think they need the same fix.
More information about the dev