[dpdk-dev] [PATCH v2 02/13] ixgbe: fix remaining pkt_flags variable size to 64 bits
thomas.monjalon at 6wind.com
Mon Nov 17 18:40:04 CET 2014
2014-11-17 18:03, Olivier MATZ:
> Hi Miroslaw,
> On 11/17/2014 05:47 PM, Walukiewicz, Miroslaw wrote:
> >> -----Original Message-----
> >> From: Olivier Matz [mailto:olivier.matz at 6wind.com]
> >> Sent: Friday, November 14, 2014 6:03 PM
> >> To: dev at dpdk.org
> >> Cc: olivier.matz at 6wind.com; Walukiewicz, Miroslaw; Liu, Jijiang; Liu, Yong;
> >> jigsaw at gmail.com; Richardson, Bruce
> >> Subject: [PATCH v2 02/13] ixgbe: fix remaining pkt_flags variable size to 64
> >> bits
> >> Since commit 4332beee9 "mbuf: expand ol_flags field to 64-bits", the
> >> packet flags are now 64 bits wide. Some occurences were forgotten in
> >> the ixgbe driver.
> > I think it should be present in separate patch. I do no not see any relation to TSO
> You are right, there is no relation with TSO. The reason why I initially
> added it in the same patchset is because I discovered this bug while
> implementing TSO and I wanted to avoid too much noise on the list.
> I can take out some patches from the series, but maybe it's too late
> and it would confuse patchwork.
> Thomas, what do you think?
In general, it's better to have only one feature in a patchset.
It's not a real problem here because TSO is planned for release 1.8 and fixes
are also welcome. So all the patches should enter in the coming days.
By the way, there is no problem with patchwork. You are free to choose :)
More information about the dev