[dpdk-dev] [memnic PATCH 7/7] pmd: split calling mbuf free
Wiles, Roger Keith
keith.wiles at windriver.com
Wed Sep 24 18:01:00 CEST 2014
On Sep 24, 2014, at 10:20 AM, Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:
> 2014-09-11 07:52, Hiroshi Shimamoto:
>> @@ -408,9 +408,9 @@ retry:
>>
>> rte_compiler_barrier();
>> p->status = MEMNIC_PKT_ST_FILLED;
>> -
>> - rte_pktmbuf_free(tx_pkts[nr]);
>> }
>> + for (i = 0; i < nr; i++)
>> + rte_pktmbuf_free(tx_pkts[i]);
>>
>> /* stats */
>> st->opackets += pkts;
>>
>
> You are bursting mbuf freeing. Why title is about "split”?
Maybe this should be a new API as in rte_pktmbuf_bulk_free(tx_pkts, nr); ??
This would remove the loop in the application and I know I have done the same thing for Pktgen too.
>
> --
> Thomas
Keith Wiles, Principal Technologist with CTO office, Wind River mobile 972-213-5533
More information about the dev
mailing list