[dpdk-dev] [PATCH] qos_meter: Fix compilation with APP_MODE_FWD

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Aug 25 15:42:55 CEST 2015

2015-08-25 13:34, Mcnamara, John:
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Thomas Monjalon
> > This patch should not be accepted to discourage build-time options.
> > Patch for run-time option is welcome.
> The patch is fixing a compilation issue, which seems reasonable. It isn't
> introducing a build time option, it is merely fixing an typo in an
> existing one.


> Yes, it would be better not to have this build time option (in which case
> the issue would have been found sooner) but that isn't the responsibility
> of the person submitting this patch.


> That is something that should be pushed back to the author/maintainer.


> In the meantime this patch is still valid and should be applied.

After trying to request this kind of cleanup for several months, nothing
happens. Maybe it will be more efficient to leave bugs until someone
submit a real cleanup.

More information about the dev mailing list