[dpdk-dev] [PATCH 1/1] doc: correct Vhost Sample Application guide

Yuanhan Liu yuanhan.liu at linux.intel.com
Thu Dec 10 07:40:46 CET 2015


On Wed, Dec 09, 2015 at 04:14:01PM +0000, Iremonger, Bernard wrote:
> Hi John,
> <snip>
> 
> > 2015-12-09 14:50, Mcnamara, John:
> > > Also, as a general note, not just to this document/patch.
> > >
> > > I don't think the "user at target:~$" prefixes used in some DPDK Doc
> > > commandlines is useful.
> > >
> > > It prevents a straight copy and paste for testing, it makes the
> > > literal block lines longer than they should be, it isn't used
> > > consistently everywhere, it is visually distracting (in some cases it
> > > is longer than the command being shown), and it isn't always correct
> > > (I presume in the above case of "user at target" you would need run the
> > > application as sudo if you are a non root user).
> > >
> > > Any objections to removing these as documents are updated?
> > 
> > Generally speaking, +1 to remove extra bytes :)
> 
> I will remove the "user at target:~$"  prefixes in this document.

I'd personally suggest to keep the "$ " prefix, or "# " if it needs
root privilege. Which is a convention to paste commands.

	--yliu



More information about the dev mailing list