[dpdk-dev] [PATCH] eal: map io resources for non x86 architectures

David Marchand david.marchand at 6wind.com
Wed Dec 16 14:29:21 CET 2015


Bruce,

On Wed, Dec 16, 2015 at 2:15 PM, Bruce Richardson <
bruce.richardson at intel.com> wrote:

>
> > +#if defined(RTE_ARCH_X86_64) || defined(RTE_ARCH_I686)
> > +             /* x86 can not remap ioports, so skip it, remapping code
> will
> > +              * look at dev->mem_resource[i].phys_addr == 0 and skip it
> */
> > +             if (flags & IORESOURCE_IO)
> > +                     continue;
> > +#endif
>
> As a tangential comment: We maybe could look to make certain preprocessor
> defines available as C globals as well. There is no reason that the ifdef
> here
> could not be implemented as a runtime check in C code.
>
>
Well, instead of having the same information as the preprocessor define,
maybe some capability per arch/cpu would be better "arch supports io remap".
Maybe we can extend the cpuflags ?


-- 
David Marchand


More information about the dev mailing list