[dpdk-dev] [PATCH v2 2/2] eal: add help option
David Marchand
david.marchand at 6wind.com
Tue Feb 3 10:07:26 CET 2015
On Tue, Feb 3, 2015 at 9:20 AM, Thomas Monjalon <thomas.monjalon at 6wind.com>
wrote:
> 2015-02-03 07:33, David Marchand:
> > On Mon, Feb 2, 2015 at 6:44 PM, Thomas Monjalon <
> thomas.monjalon at 6wind.com>
> > wrote:
> > [snip]
> > > @@ -340,6 +342,9 @@ eal_parse_args(int argc, char **argv)
> > > continue;
> > >
> > > switch (opt) {
> > > + case 'h':
> > > + eal_usage(prgname);
> > > + exit(EXIT_SUCCESS);
> > > default:
> > > if (opt < OPT_LONG_MIN_NUM && isprint(opt)) {
> > > RTE_LOG(ERR, EAL, "Option %c is not
> supported "
> > [snip]
> > > @@ -534,6 +536,10 @@ eal_parse_args(int argc, char **argv)
> > > continue;
> > >
> > > switch (opt) {
> > > + case 'h':
> > > + eal_usage(prgname);
> > > + exit(EXIT_SUCCESS);
> > > +
> > > /* force loading of external driver */
> > > case 'd':
> > > solib = malloc(sizeof(*solib));
> >
> > Why not move those two in common parser ?
>
> Because it's calling eal_usage() which is not callable from common parser.
> eal_usage() print usage for common and environment-specific options.
>
Oh right ...
Then, I suppose it is fine like this.
Acked-by: David Marchand <david.marchand at 6wind.com>
--
David Marchand
More information about the dev
mailing list