[dpdk-dev] [PATCH] enic: silence log message

[David Marchand]

On Sun, Feb 8, 2015 at 6:36 PM, Stephen Hemminger <
stephen at networkplumber.org> wrote:

> From: Stephen Hemminger <shemming at brocade.com>
>
> Silence is normal. drivers should speak only when spoken to and not
> be chatty.
>
> Signed-off-by: Stephen Hemminger <stephen at networkplumber.org>
> ---
>  lib/librte_pmd_enic/enic_main.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/lib/librte_pmd_enic/enic_main.c
> b/lib/librte_pmd_enic/enic_main.c
> index 48fdca2..dad8922 100644
> --- a/lib/librte_pmd_enic/enic_main.c
> +++ b/lib/librte_pmd_enic/enic_main.c
> @@ -1046,8 +1046,6 @@ int enic_probe(struct enic *enic)
>         struct rte_pci_device *pdev = enic->pdev;
>         int err = -1;
>
> -       dev_info(enic, " Initializing ENIC PMD version %s\n", DRV_VERSION);
> -
>         enic->bar0.vaddr = (void *)pdev->mem_resource[0].addr;
>         enic->bar0.len = pdev->mem_resource[0].len;
>

NAK.

The main problem is that enic pmd is using printf to write logs.
So the pmd should be fixed so that dev_* macros use RTE_LOG.

Silence is good when it is the default behaviour.
But I prefer we can change this at runtime, rather than strip the log
messages, especially for init.


-- 
David Marchand