[dpdk-dev] [PATCH v4 12/17] eal: set _lcore_id and _socket_id to (-1) by default

[Ananyev, Konstantin]

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Liang, Cunming
> Sent: Tuesday, February 10, 2015 2:54 AM
> To: Olivier MATZ; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v4 12/17] eal: set _lcore_id and _socket_id to (-1) by default
> 
> 
> 
> > -----Original Message-----
> > From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
> > Sent: Tuesday, February 10, 2015 1:49 AM
> > To: Liang, Cunming; dev at dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH v4 12/17] eal: set _lcore_id and _socket_id to (-1)
> > by default
> >
> > Hi,
> >
> > On 02/09/2015 03:24 PM, Liang, Cunming wrote:
> > >>> --- a/lib/librte_eal/linuxapp/eal/eal_thread.c
> > >>> +++ b/lib/librte_eal/linuxapp/eal/eal_thread.c
> > >>> @@ -57,8 +57,8 @@
> > >>>  #include "eal_private.h"
> > >>>  #include "eal_thread.h"
> > >>>
> > >>> -RTE_DEFINE_PER_LCORE(unsigned, _lcore_id);
> > >>> -RTE_DEFINE_PER_LCORE(unsigned, _socket_id);
> > >>> +RTE_DEFINE_PER_LCORE(unsigned, _lcore_id) = (unsigned)LCORE_ID_ANY;
> > >>> +RTE_DEFINE_PER_LCORE(unsigned, _socket_id) =
> > (unsigned)SOCKET_ID_ANY;
> > >>>  RTE_DEFINE_PER_LCORE(rte_cpuset_t, _cpuset);
> > >>
> > >> As far as I understand, now a rte_lcore_id() can return LCORE_ID_ANY.
> > >> This should be modified in the rte_lcore_id() API comments.
> > >>
> > >> Same for rte_socket_id().
> > > [LCM] accept.
> > >>
> > >> I also wonder if the API of these functions should be modified to
> > >> return an int instead of an unsigned as LCORE_ID_ANY is -1.
> > > [LCM] I prefer not change the API definition. (unsigned)LCORE_ID_ANY already
> > used before.
> >
> > OK
> >
> > And what about directly defining the following?
> >
> > #define LCORE_ID_ANY ((unsigned)-1)
> >
> >
> > It would avoid the casts.
> [LCM] Good point, will update it.

UINT32_MAX ?