[dpdk-dev] [PATCH] af_packet: fix minor memory leak of kvlist in dev init
John McNamara
john.mcnamara at intel.com
Mon Feb 23 14:29:16 CET 2015
Fix for Klockwork identified issue.
Signed-off-by: John McNamara <john.mcnamara at intel.com>
---
lib/librte_pmd_af_packet/rte_eth_af_packet.c | 11 ++++++++---
1 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/lib/librte_pmd_af_packet/rte_eth_af_packet.c b/lib/librte_pmd_af_packet/rte_eth_af_packet.c
index 1ffe1cd..7ee3b31 100644
--- a/lib/librte_pmd_af_packet/rte_eth_af_packet.c
+++ b/lib/librte_pmd_af_packet/rte_eth_af_packet.c
@@ -803,7 +803,7 @@ rte_pmd_af_packet_devinit(const char *name, const char *params)
{
unsigned numa_node;
int ret;
- struct rte_kvargs *kvlist;
+ struct rte_kvargs *kvlist = NULL;
int sockfd = -1;
RTE_LOG(INFO, PMD, "Initializing pmd_af_packet for %s\n", name);
@@ -823,16 +823,21 @@ rte_pmd_af_packet_devinit(const char *name, const char *params)
ret = rte_kvargs_process(kvlist, ETH_AF_PACKET_IFACE_ARG,
&open_packet_iface, &sockfd);
if (ret < 0)
- return -1;
+ goto out;
}
ret = rte_eth_from_packet(name, &sockfd, numa_node, kvlist);
close(sockfd); /* no longer needed */
if (ret < 0)
- return -1;
+ goto out;
+ rte_kvargs_free(kvlist);
return 0;
+
+out:
+ rte_kvargs_free(kvlist);
+ return -1;
}
static struct rte_driver pmd_af_packet_drv = {
--
1.7.4.1
More information about the dev
mailing list