[dpdk-dev] ret_pktmbuf_pool_init problem with opaque_arg

Stephen Hemminger stephen at networkplumber.org
Fri Jan 9 23:42:16 CET 2015


On Fri, 9 Jan 2015 14:12:10 +0000
Alejandro Lucero <alejandro.lucero at netronome.com> wrote:

> Inside this function mbuf_data_room_size is set to a default value if
> opaque_arg is null and it should be set to the value pointed by opaque_arg
> if not null. Current implementation is using not the value but with the
> pointer itself. I think this:
> 
>         roomsz = (uint16_t)(uintptr_t)opaque_arg;
> 
> should be something like this:
> 
>         roomsz = *(uint16_t *)opaque_arg;

That would require an extra value in persistent (not stack) for the size.
The way that is implemented, the caller can just pass the value by
casting to unsigned long.


More information about the dev mailing list