[dpdk-dev] [PATCH v9 01/12] eal: Fix coding style of eal_pci.c and eal_pci_uio.c

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Jul 8 22:30:51 CEST 2015


2015-07-08 09:09, Stephen Hemminger:
> On Wed,  8 Jul 2015 19:34:42 +0900
> Tetsuya Mukawa <mukawa at igel.co.jp> wrote:
> 
> > diff --git a/lib/librte_eal/bsdapp/eal/eal_pci.c b/lib/librte_eal/bsdapp/eal/eal_pci.c
> > index 2df5c1c..a63d450 100644
> > --- a/lib/librte_eal/bsdapp/eal/eal_pci.c
> > +++ b/lib/librte_eal/bsdapp/eal/eal_pci.c
> > @@ -2,6 +2,7 @@
> >   *   BSD LICENSE
> >   *
> >   *   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.
> > + *   Copyright(c) 2015 IGEL Co., Ltd.
> 
> I think copyright in file should stay with original author, otherwise
> the Copyright will keep growing with all patches.

Yes you're right.
There is no strict rule, but Copyright should be added only in new files
or with a really significant change.

Tetsuya, you have copyright on PMD null and hotplug framework in doc.
Hope you'll agree to not add new ones while doing some EAL cleanup.


More information about the dev mailing list