[dpdk-dev] [PATCH v4] enforce rules of the cpu and ixgbe exchange data.

[Ananyev, Konstantin]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, July 27, 2015 3:18 PM
> To: Ananyev, Konstantin
> Cc: xuelin.shi at freescale.com; dev at dpdk.org
> Subject: Re: [PATCH v4] enforce rules of the cpu and ixgbe exchange data.
> 
> A quick review of this long pending patch would be great.
> Thanks

Well, it doesn't compile:

/local/kananye1/dpdk.org-ixgbevfix2-tst1/drivers/net/ixgbe/ixgbe_rxtx.c: In function âixgbe_rx_scan_hw_ringâ:
/local/kananye1/dpdk.org-ixgbevfix2-tst1/drivers/net/ixgbe/ixgbe_rxtx.c:1114:4: error: implicit declaration of function ârte_le_to_cpu16â [-Werror=implicit-function-declaration]
    pkt_len = rte_le_to_cpu16(rxdp[j].wb.upper.length) -
    ^
/local/kananye1/dpdk.org-ixgbevfix2-tst1/drivers/net/ixgbe/ixgbe_rxtx.c:1114:4: error: nested extern declaration of ârte_le_to_cpu16â [-Werror=nested-externs]


Should be rte_le_to_cpu_16(), I believe.

And checkpatch.pl complains on it:

WARNING: line over 80 characters
#151: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1133:
+                               rte_le_to_cpu_32(rxdp[j].wb.lower.lo_dword.data));

ERROR: code indent should use tabs where possible
#170: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1147:
+^I^I^I ^I    rxdp[j].wb.lower.hi_dword.csum_ip.csum) &$

WARNING: please, no space before tabs
#170: FILE: drivers/net/ixgbe/ixgbe_rxtx.c:1147:
+^I^I^I ^I    rxdp[j].wb.lower.hi_dword.csum_ip.csum) &$

total: 1 errors, 2 warnings, 192 lines checked

Apart from that, looks harmless :)

Konstantin

> 
> 2015-07-16 14:45, xuelin.shi at freescale.com:
> > From: Xuelin Shi <xuelin.shi at freescale.com>
> >
> > 1. cpu use data owned by ixgbe must use rte_le_to_cpu_xx(...)
> > 2. cpu fill data to ixgbe must use rte_cpu_to_le_xx(...)
> > 3. checking pci status with converted constant.
> >
> > Signed-off-by: Xuelin Shi <xuelin.shi at freescale.com>