[dpdk-dev] [PATCH] librte_eal/common: Fix cast from pointer to integer of different size
Gonzalez Monroy, Sergio
sergio.gonzalez.monroy at intel.com
Mon Mar 2 12:39:47 CET 2015
On 02/03/2015 07:27, Michael Qiu wrote:
> /i686-native-linuxapp-gcc/include/rte_memcpy.h:592:23: error:
> cast from pointer to integer of different size
> [-Werror=pointer-to-int-cast]
>
> dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
>
> Type 'long long' is 64-bit in i686 platform while 'void *'
> is 32-bit.
>
> Signed-off-by: Michael Qiu <michael.qiu at intel.com>
> ---
> lib/librte_eal/common/include/arch/x86/rte_memcpy.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
> index 7b2d382..6565c00 100644
> --- a/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
> +++ b/lib/librte_eal/common/include/arch/x86/rte_memcpy.h
> @@ -589,12 +589,12 @@ COPY_BLOCK_64_BACK15:
> * unaligned copy functions require up to 15 bytes
> * backwards access.
> */
> - dstofss = 16 - (int)((long long)(void *)dst & 0x0F) + 16;
> + dstofss = 16 - (int)((long)(void *)dst & 0x0F) + 16;
You may as well remove the (void *) casting, I don't think it is necessary.
> n -= dstofss;
> rte_mov32((uint8_t *)dst, (const uint8_t *)src);
> src = (const uint8_t *)src + dstofss;
> dst = (uint8_t *)dst + dstofss;
> - srcofs = (int)((long long)(const void *)src & 0x0F);
> + srcofs = (int)((long)(const void *)src & 0x0F);
Same here for (const void *)
Sergio
>
> /**
> * For aligned copy
More information about the dev
mailing list