[dpdk-dev] [PATCH 00/10] eal: rte_tailq api cleanup

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Mar 10 12:20:02 CET 2015


2015-03-05 19:26, Neil Horman:
> On Wed, Mar 04, 2015 at 10:50:00PM +0100, David Marchand wrote:
> > This is a first cleanup at trying to remove references to other dpdk libraries
> > from eal.
> > 
> > This cleanup is focused on rte_tailq api which has been marked as "for internal
> > use" for quite some time now.
> > Rather than have a static list in eal for all users of rte_tailq, a new register
> > system is introduced.
> > This register system uses constructors which have no access to dpdk shared
> > memory, so a two step registration is done: first step inserts the requested
> > tailq in a local list ("local" in multi process context), then in second step,
> > eal init allocates/looks up for a real tailq from shared memory for all elements
> > of this local list.
> > 
> > I have tried to think of different cases (libraries loaded before/after eal
> > init...). The unit tests have been updated accordingly.
> > 
> > 
> This all seems pretty reasonable.
> 
> It might make sense to add a deprecation notice for this, since its removing
> public macros, but since we're not really doing that until the 2.0 release is
> out, I think we can skip it
> 
> For the series
> Acked-by: Neil Horman <nhorman at tuxdriver.com>

Applied, thanks


More information about the dev mailing list