[dpdk-dev] [PATCH] mk: added make target to print out system info

[Olivier MATZ]

Hi,

On 03/24/2015 06:00 PM, Neil Horman wrote:
> On Tue, Mar 24, 2015 at 02:52:59PM +0000, John McNamara wrote:
>> Added a 'make system_info' target to print out system info
>> related to DPDK. This is intended as output that can be
>> attached to bug reports.
>> ---
>>   mk/rte.sdkroot.mk | 33 +++++++++++++++++++++++++++++++++
>>   1 file changed, 33 insertions(+)
>>
>> diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk
>> index e8423b0..b477d09 100644
>> --- a/mk/rte.sdkroot.mk
>> +++ b/mk/rte.sdkroot.mk
>> @@ -123,3 +123,36 @@ examples examples_clean:
>>   %:
>>   	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig
>>   	$(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk $@
>> +
>> +.PHONY: system_info
>> +system_info:
>> +	$(Q)echo
>> +	$(Q)echo "CC version"
>> +	$(Q)echo "=========="
>> +	$(Q)$(CC) --version
>> +	$(Q)echo
>> +
>> +	$(Q)echo "DPDK version"
>> +	$(Q)echo "============"
>> +	$(Q)$(MAKE) showversion
>> +	$(Q)echo
>> +
>> +	$(Q)echo "Git commit"
>> +	$(Q)echo "=========="
>> +	$(Q)git log --pretty=format:'%H' -1
>> +	$(Q)echo
>> +
>> +	$(Q)echo "Uname"
>> +	$(Q)echo "====="
>> +	$(Q)uname -srvmpio
>> +	$(Q)echo
>> +
>> +	$(Q)echo "Hugepages"
>> +	$(Q)echo "========="
>> +	$(Q)grep -i huge /proc/meminfo
>> +	$(Q)echo
>> +
>> +	$(Q)tools/cpu_layout.py
>> +
>> +	$(Q)tools/dpdk_nic_bind.py --status
>> +	$(Q)echo
>> --
>> 1.8.1.4
>>
>>
> Nak, for a few reasons:
>
> 1) While this target is in a common makefile, at least some of the information
> it gathers is operating system specfic (e.g. /proc/meminfo).  This isn't going
> to work on BSD, or other operating systems that we might support in the future
>
> 2) This is tied to the build system.  Theres no guarantee that users will
> diagnose problems only on the system that they built the DPDK on.
>
> A better solution might be to simply document the sort of information that a bug
> reporter is expected to gather, along with some sample tools for doing so.
> There are numerous tools to get the above information, both in isolation and in
> aggregate.

I agree with Neil that the Makefile is probably not the best place to
put that because the target machine may not be the build machine. What
about doing the same in a script? Therefore it could be embedded and
executed on the target.

Neil, you talk about tools that do the same kind of things. What tool
are you thinking about? The problem of using external tools is that it
adds a dependency with them.


Regards,
Olivier