[dpdk-dev] [PATCH] Remove NO_AUTOLIBS option

Thomas Monjalon thomas.monjalon at 6wind.com
Tue May 12 15:07:14 CEST 2015


2015-05-01 09:29, Keith Wiles:
> NO_AUTOLIBS is not required as it was not used or defined in the config files.
> 
> Signed-off-by: Keith Wiles <keith.wiles at intel.com>
> ---
>  mk/rte.app.mk | 5 -----
>  1 file changed, 5 deletions(-)

Thanks Keith for trying to clean it, but removing half of an obsolete feature
is not a real clean-up ;)
When running "git grep NO_AUTOLIBS", it will return results in
doc/guides/prog_guide

I fixed the doc and manually applied your patch based on your _LDLIBS-y patch.
Maybe I'm too kind, I know people who whould refuse this patch :)

Sorry for being long here, but I want to show the work done when applying
patches and I want to ask: is it a good thing to manually fix patches in order
to speed-up the process or should it be more strict?


More information about the dev mailing list