[dpdk-dev] [PATCH 00/19] Move PMDs to drivers directory

Thomas Monjalon thomas.monjalon at 6wind.com
Wed May 13 15:33:27 CEST 2015


2015-05-13 11:01, Bruce Richardson:
> On Tue, May 12, 2015 at 09:30:45PM +0200, Thomas Monjalon wrote:
>> 2015-05-12 19:04, Bruce Richardson:
>>>  drivers/e1000/e1000/e1000_hw.h                     | 1026 ++++
>>
>> As explained in a previous comment,
>> http://dpdk.org/ml/archives/dev/2015-May/017509.html
>> I think this path would be better:
>>    drivers/net/e1000/base/e1000_hw.h
> 
> Two reasons why I didn't create the "net" subfolder:
> 1. I initally forgot to consider it :-(
> 2. While we may at some future point have other device driver types, are we really
> needing to start categorising PMDs at this point?
> 
> As for the base driver part, I was viewing that as a something that should be
> a separate patch set, since it's unrelated to moving things to the drivers
> subdir.

I understand your points and I partially agree.
However, file moves may be perturbing because it change habits
and may complicate a bit the git history browsing.
So I think it's better to minimize such moves and do altogether.



More information about the dev mailing list