[dpdk-dev] [PATCH v2 06/19] enic: move enic PMD to drivers/net directory

[Sujith Sankar (ssujith)]

On 20/05/15 9:44 pm, "Thomas Monjalon" <thomas.monjalon at 6wind.com> wrote:

>2015-05-20 16:04, Richardson, Bruce:
>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
>> > 2015-05-15 16:56, Bruce Richardson:
>> > > move enic PMD to drivers/net directory
>> > >
>> > > Signed-off-by: Bruce Richardson <bruce.richardson at intel.com>
>> > > ---
>> > >  drivers/net/Makefile                         |    2 +-
>> > >  drivers/net/enic/LICENSE                     |   27 +
>> > >  drivers/net/enic/Makefile                    |   71 ++
>> > >  drivers/net/enic/enic.h                      |  200 +++++
>> > >  drivers/net/enic/enic_clsf.c                 |  259 ++++++
>> > >  drivers/net/enic/enic_compat.h               |  147 ++++
>> > >  drivers/net/enic/enic_ethdev.c               |  640 +++++++++++++++
>> > >  drivers/net/enic/enic_main.c                 | 1117
>> > ++++++++++++++++++++++++++
>> > >  drivers/net/enic/enic_res.c                  |  219 +++++
>> > >  drivers/net/enic/enic_res.h                  |  168 ++++
>> > >  drivers/net/enic/rte_pmd_enic_version.map    |    4 +
>> > >  drivers/net/enic/vnic/cq_desc.h              |  126 +++
>> > >  drivers/net/enic/vnic/cq_enet_desc.h         |  261 ++++++
>> > >  drivers/net/enic/vnic/rq_enet_desc.h         |   76 ++
>> > >  drivers/net/enic/vnic/vnic_cq.c              |  117 +++
>> > >  drivers/net/enic/vnic/vnic_cq.h              |  151 ++++
>> > >  drivers/net/enic/vnic/vnic_dev.c             | 1054
>> > ++++++++++++++++++++++++
>> > >  drivers/net/enic/vnic/vnic_dev.h             |  212 +++++
>> > >  drivers/net/enic/vnic/vnic_devcmd.h          |  774
>>++++++++++++++++++
>> > >  drivers/net/enic/vnic/vnic_enet.h            |   78 ++
>> > >  drivers/net/enic/vnic/vnic_intr.c            |   78 ++
>> > >  drivers/net/enic/vnic/vnic_intr.h            |  126 +++
>> > >  drivers/net/enic/vnic/vnic_nic.h             |   88 ++
>> > >  drivers/net/enic/vnic/vnic_resource.h        |   97 +++
>> > >  drivers/net/enic/vnic/vnic_rq.c              |  245 ++++++
>> > >  drivers/net/enic/vnic/vnic_rq.h              |  282 +++++++
>> > >  drivers/net/enic/vnic/vnic_rss.c             |   85 ++
>> > >  drivers/net/enic/vnic/vnic_rss.h             |   61 ++
>> > >  drivers/net/enic/vnic/vnic_stats.h           |   86 ++
>> > >  drivers/net/enic/vnic/vnic_wq.c              |  245 ++++++
>> > >  drivers/net/enic/vnic/vnic_wq.h              |  283 +++++++
>> > >  drivers/net/enic/vnic/wq_enet_desc.h         |  114 +++
>> > 
>> > I think that vnic/ should be renamed to base/
>> 
>> Yes, I was wondering about that. However, this wasn't a driver I was
>>familiar with and its origins, so I left it as-is.
>
>Sujith imported it with this message:
>"VNIC common code partially shared with ENIC kernel mode driver"
>http://dpdk.org/ml/archives/dev/2014-November/008716.html

Please go ahead with the renaming.
Is this just for uniformity?  Is there any other reason?

Thanks,
-Sujith

>