[dpdk-dev] [PATCH 3/3] ethdev: prevent segfaults in rte_eth_dev_is_detachable

Thomas Monjalon thomas.monjalon at 6wind.com
Tue Nov 3 12:20:02 CET 2015


2015-11-03 12:19, David Marchand:
> On Tue, Nov 3, 2015 at 12:10 PM, Thomas Monjalon <thomas.monjalon at 6wind.com>
> wrote:
> 
> > 2015-10-29 09:55, David Marchand:
> > > From: Maxime Leroy <maxime.leroy at 6wind.com>
> > >
> > > Some drivers like virtual ones don't specify any driver pointer in the
> > > structure rte_eth_dev.
> > >
> > > To prevent segfault, we should check if this pointer is NULL before
> > > dereferencing it.
> > >
> > > Signed-off-by: Maxime Leroy <maxime.leroy at 6wind.com>
> > > Signed-off-by: David Marchand <david.marchand at 6wind.com>
> >
> > It is not clear what the problem is.
> > And the driver fields should probably be removed or changed as it too
> > tigthly
> > related to the PCI driver.
> >
> 
> It does look odd to me as well, quickly went through head, and did not see
> a case where this could happen.
> Maxime is not available at the moment, so I think I will just drop this
> patch.
> 
> How about this patchset rebased on head with just the first two patches ?

Perfect, thanks


More information about the dev mailing list