[dpdk-dev] [PATCH] vhost: eventfd_link's minor number shall be specified

Yuanhan Liu yuanhan.liu at linux.intel.com
Mon Nov 9 05:22:37 CET 2015


On Fri, Nov 06, 2015 at 02:04:37PM +0800, Xiaobo Chi wrote:
>  eventfd_link_misc's minor number shall be MISC_DYNAMIC_MINOR to let Linux kernel dynamically assign one while loading.

For such (fix) patch, I'd like to see what exact issue your patch fixes.

And if it fixes an issue, you'd better title your patch with something
like "vhost: fix ...", so that it's likely Thomas will put it into
high priority.

	--yliu

> 
> Signed-off-by: Xiaobo Chi <xiaobo.chi at nokia.com>
> ---
>  lib/librte_vhost/eventfd_link/eventfd_link.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_vhost/eventfd_link/eventfd_link.c b/lib/librte_vhost/eventfd_link/eventfd_link.c
> index c54a938..4b05b5a 100644
> --- a/lib/librte_vhost/eventfd_link/eventfd_link.c
> +++ b/lib/librte_vhost/eventfd_link/eventfd_link.c
> @@ -249,6 +249,7 @@ static const struct file_operations eventfd_link_fops = {
>  
>  
>  static struct miscdevice eventfd_link_misc = {
> +	.minor = MISC_DYNAMIC_MINOR,
>  	.name = "eventfd-link",
>  	.fops = &eventfd_link_fops,
>  };
> -- 
> 1.9.4.msysgit.2


More information about the dev mailing list