[dpdk-dev] [PATCH 0/3] Support for Netronome´s NFP-6xxx card

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Alejandro.Lucero
> Sent: Friday, October 2, 2015 12:26 PM
> To: dev at dpdk.org
> Subject: [dpdk-dev] [PATCH 0/3] Support for Netronome´s NFP-6xxx card
> 
> From: "Alejandro.Lucero" <alejandro.lucero at netronome.com>
> 
> Alejandro.Lucero (3):
>   This patch adds a PMD driver for Netronome NFP PCI cards.
>   This patch adds a new UIO driver for Netronome NFP PCI cards.
>   Modifying configuration scripts for Netronome's nfp_uio driver.

Hi,

Thank you for submitting this. It is a good addition to DPDK.

Some minor comments to help the patchset get accepted.

It looks like the DPDK coding standard has been applied but check the guidelines for any differences:

    http://dpdk.org/doc/guides/contributing/coding_style.html

It is also worth checking the patchset with the Linux kernel checkpatch utility. Not all kernel warnings are relevant to DPDK but most are. The following is an example check:

   linux/scripts/checkpatch.pl --ignore PREFER_KERNEL_TYPES,SPLIT_STRING,VOLATILE -q patches*.patch

The first patch contains a doc patch. These are generally submitted in a separate patch as part of the patchset. Also it needs an addition to the index in doc/guides/nics/index.rst to actually include it in the documentation. Finally the RST has a few minor issues. See the doc guidelines for a how-to on installing and running the doc build system and the suggested formatting for the documentation.

    http://dpdk.org/doc/guides/contributing/documentation.html

John.
--