[dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss configuration

Kulasek, TomaszX tomaszx.kulasek at intel.com
Thu Oct 15 10:42:23 CEST 2015


> -----Original Message-----
> From: Tetsuya Mukawa [mailto:mukawa at igel.co.jp]
> Sent: Thursday, October 15, 2015 09:46
> To: Kulasek, TomaszX; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v5 4/9] null: virtual dynamic rss
> configuration
> 
> On 2015/09/30 23:05, Tomasz Kulasek wrote:
> > This implementation allows to set and read RSS configuration for null
> > device, and is used to validate right values propagation over the
> > slaves, in test units for dynamic RSS configuration for bonding.
> >
> > v5 changes:
> >  - replaced memcpy with rte_memcpy
> >
> > Signed-off-by: Tomasz Kulasek <tomaszx.kulasek at intel.com>
> > ---
> >  drivers/net/null/rte_eth_null.c |  116
> > +++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 116 insertions(+)
> >
> > diff --git a/drivers/net/null/rte_eth_null.c
> > b/drivers/net/null/rte_eth_null.c index bf81b1b..b01f647 100644
> > --- a/drivers/net/null/rte_eth_null.c
> > +++ b/drivers/net/null/rte_eth_null.c
> > @@ -37,6 +37,8 @@
> >  #include <rte_memcpy.h>
> >  #include <rte_dev.h>
> >  #include <rte_kvargs.h>
> > +#include <rte_eth_null.h>
> > +#include <rte_spinlock.h>
> >
> >
> 
> 
> Hi Tomasz,
> 
> We don't have "rte_eth_null.h" at this point.
> (The header file will be added next patch) Probably, we also need
> "rte_pmd_null_version.map" to compile correctly.
> (To make sure, please compile DPDK with "CONFIG_RTE_BUILD_SHARED_LIB=y"
> option.)
> 
> Also, it seems 'rte_eth_null.h' should be included like below.
> #include "rte_eth_null.h"
> Without it, we cannot compile.
> 
> Thanks,
> Tetsuya

Hi Tetsuya,

This file and modifications are already included in "[dpdk-dev,v5,5/9] null: export eth_dev_null_create" in the patch set, also the required symlink is created like below:

---
diff --git a/drivers/net/null/Makefile b/drivers/net/null/Makefile
index 96ba01c..2202389 100644
--- a/drivers/net/null/Makefile
+++ b/drivers/net/null/Makefile
@@ -51,7 +51,7 @@  SRCS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += rte_eth_null.c
 #
 # Export include files
 #
-SYMLINK-y-include +=
+SYMLINK-y-include += rte_eth_null.h
 
 # this lib depends upon:
 DEPDIRS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += lib/librte_mbuf
---

Tomasz.



More information about the dev mailing list