[dpdk-dev] [PATCH 10/11] mk: add makefile and config changes for armv8 architecture

[Jan Viktorin]

On Mon, 26 Oct 2015 17:22:01 +0100
Jan Viktorin <viktorin at rehivetech.com> wrote:

> On Fri, 23 Oct 2015 15:17:12 +0100
> David Hunt <david.hunt at intel.com> wrote:
> 
> >  
> > +# ARMv8 CPU flags
> > +ifneq ($(filter $(AUTO_CPUFLAGS),__aarch64__),)

I do not believe that this works. The function filter accepts
arguments swapped. I.e. first a pattern and then the list of
filtered data. I suppose, __aarch64__ is the pattern...

Jan

> > +CPUFLAGS += AARCH64
> > +endif
> > +
> > +ifneq ($(filter $(AUTO_CPUFLAGS),__aarch32__),)
> > +CPUFLAGS += AARCH32
> > +endif
> > +  
> 
> I think, this should go with the ARMv7 series.

> 
> Jan
> 



-- 
   Jan Viktorin                  E-mail: Viktorin at RehiveTech.com
   System Architect              Web:    www.RehiveTech.com
   RehiveTech
   Brno, Czech Republic