[dpdk-dev] [PATCH v6 1/3] i40e: RSS/FD granularity configuration

[Zhang, Helin]

> -----Original Message-----
> From: Richardson, Bruce
> Sent: Thursday, October 29, 2015 5:39 PM
> To: Zhang, Helin
> Cc: dev at dpdk.org; Pei, Yulong
> Subject: Re: [dpdk-dev] [PATCH v6 1/3] i40e: RSS/FD granularity configuration
> 
> On Thu, Oct 29, 2015 at 02:02:50PM +0800, Helin Zhang wrote:
> > The default input set of fields of a received packet are loaded from
> > firmware, which cannot be modified even users want to use different
> > fields for RSS or flow director. Here adds more flexibilities of
> > selecting packet fields for hash calculation or flow director for
> > users.
> >
> > Signed-off-by: Helin Zhang <helin.zhang at intel.com>
> > Signed-off-by: Andrey Chilikin <andrey.chilikin at intel.com>
> > ---
> >  drivers/net/i40e/i40e_ethdev.c  | 742
> ++++++++++++++++++++++++++++++++++++++++
> >  drivers/net/i40e/i40e_ethdev.h  |   7 +
> >  drivers/net/i40e/i40e_fdir.c    |  31 ++
> >  lib/librte_ether/rte_eth_ctrl.h | 114 +++++-
> >  4 files changed, 890 insertions(+), 4 deletions(-)
> >
> <snip>
> > @@ -672,6 +776,8 @@ struct rte_eth_hash_filter_info {
> >  		uint8_t enable;
> >  		/** Global configurations of hash filter */
> >  		struct rte_eth_hash_global_conf global_conf;
> > +		/** Global configurations of hash filter input set */
> > +		struct rte_eth_input_set_conf input_set_conf;
> >  	} info;
> >  };
> >
> Hi Helin,
> 
> Just to check: Does this change affect the size of the structure and cause ABI
> issues?

Bruce, you are right, there should be ABI issue with the structure size. Thank you very much!
I will change the size of ' struct rte_eth_input_set_conf ' to smaller one, and then no ABI issue this time.
But I will announce ABI change to support configuring more than one input sets, and then make the change next time.

/Helin

> 
> /Bruce