[dpdk-dev] [PATCH v1] net: i40e: add VLAN tag size to RXMAX

Zhang, Helin helin.zhang at intel.com
Tue Sep 1 07:34:28 CEST 2015



> -----Original Message-----
> From: Vlad Zolotarov [mailto:vladz at cloudius-systems.com]
> Sent: Monday, August 31, 2015 2:42 PM
> To: dev at dpdk.org
> Cc: Zhang, Helin; Ananyev, Konstantin; avi at cloudius-systems.com; Vlad
> Zolotarov
> Subject: [dpdk-dev] [PATCH v1] net: i40e: add VLAN tag size to RXMAX
> 
> HW requires it regardless the presence of the VLAN tag in the received frame.
> Otherwise Rx frames are being filtered out on the MTU-4 boundary.
Maximum packet length could have different meanings from MTU. I agree with
you to have it be regardless of vlan tag length.

> 
> Signed-off-by: Vlad Zolotarov <vladz at cloudius-systems.com>
> ---
>  drivers/net/i40e/i40e_rxtx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
> eae4ab0..22aaeb1 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -3156,7 +3156,7 @@ i40e_rx_queue_init(struct i40e_rx_queue *rxq)
>  		rx_ctx.hsplit_0 = I40E_HEADER_SPLIT_ALL;
>  	else
>  		rx_ctx.hsplit_0 = I40E_HEADER_SPLIT_NONE;
> -	rx_ctx.rxmax = rxq->max_pkt_len;
> +	rx_ctx.rxmax = rxq->max_pkt_len + I40E_VLAN_TAG_SIZE;
It needs to take into account the double vlan case, and also VF case.
It seems it needs more code changes. Thank you for the contribution!

Regards,
Helin

>  	rx_ctx.tphrdesc_ena = 1;
>  	rx_ctx.tphwdesc_ena = 1;
>  	rx_ctx.tphdata_ena = 1;
> --
> 2.1.0



More information about the dev mailing list