[dpdk-dev] [PATCH] igb_uio: use existing PCI macros

Ferruh Yigit ferruh.yigit at intel.com
Thu Sep 10 21:33:00 CEST 2015


Hi David,
> Hello Ferruh,
> 
> On Thu, Sep 10, 2015 at 6:01 PM, Ferruh Yigit <ferruh.yigit at intel.com>
> wrote:
> 
> > To get pci_dev and vf number from dev, benefit from
> > existing macros in pci.h
> >
> > Signed-off-by: Ferruh Yigit <ferruh.yigit at intel.com>
> >
> 
> Correct me if I am wrong but you might need to provide wrappers for kernel
> version <= 2.6.34 (or something that indicates availability of those).

Correct, those macros available after kernel version >= 2.6.34.
If these is any chance that one using older kernel than this version,
instead of having wrappers I am for keeping existing implementation and
drop this patch.

> 
> Please, can you confirm this is just a cleanup and you are not fixing
> anything ?

Just cleanup.

Thanks,
ferruh


More information about the dev mailing list