[dpdk-dev] [PATCH v2] ixgbe: fix access to last byte of EEPROM

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Sep 17 12:13:23 CEST 2015


2015-09-17 10:05, Remy Horton:
> Incorrect operator in ixgbe_get_eeprom & ixgbe_set_eeprom prevents
> last byte of EEPROM being read/written, and hence cannot be dumped
> or updated in entirity using these functions.
> 
> Signed-off-by: Remy Horton <remy.horton at intel.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

>From my previous comment:
"
Then creating a commit starting with "fix" should trigger 2 other things:
        - a Fixes: tag
        - an update in the release notes (because the bug exists in previous releases)
"

Maybe it does not deserve an entry in the release notes if the bug
has no real impact.



More information about the dev mailing list