[dpdk-dev] [PATCH v1 1/3] port: add mp/mc ring ports

[Stephen Hemminger]

On Tue, 22 Sep 2015 16:23:51 +0200
Thomas Monjalon <thomas.monjalon at 6wind.com> wrote:

> 2015-09-22 11:34, Dumitrescu, Cristian:
> > 
> > > -----Original Message-----
> > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen
> > > Hemminger
> > > Sent: Tuesday, September 22, 2015 1:36 AM
> > > To: Azarewicz, PiotrX T
> > > Cc: dev at dpdk.org
> > > Subject: Re: [dpdk-dev] [PATCH v1 1/3] port: add mp/mc ring ports
> > > 
> > > On Tue, 15 Sep 2015 15:06:33 +0200
> > > Piotr Azarewicz <piotrx.t.azarewicz at intel.com> wrote:
> > > 
> > > > +static inline void
> > > > +send_burst_mp(struct rte_port_ring_writer *p)
> > > > +{
> > > 
> > > compiler will inline static functions anyway. No need to add inline qualifier
> > 
> > Hi Stephen,
> > 
> > Using 'static inline' seems to be the standard practice in DPDK and a good practice as well.
> 
> Why do you think it is a good practice?
> Forced inlining can be a random optimization having negative effects.

Agreed. Modern compilers make good decisions.