[dpdk-dev] "cannot use T= with gcov target" when doing "makefile clean" with DPDK-2.1.0

Montorsi, Francesco fmontorsi at empirix.com
Tue Sep 29 18:06:52 CEST 2015


Hi Olivier,
Sorry for the delay:

> -----Original Message-----
> From: Olivier MATZ [mailto:olivier.matz at 6wind.com]
> I had a look to your test case, I think the second command is not correct. The
> T= parameter is not allowed for the clean target. It should be something like
> this:
> 
>   # configure a workspace using template specified by T= in the
>   # directory specified by O=
>   make T=x86_64-native-linuxapp-gcc O=x86_64-native-linuxapp-gcc config
> 
>   # clean the directory specified by O=
>   make O=x86_64-native-linuxapp-gcc clean
> 
> See "make help" for details.
> 
> 
> I think the proper patch would be to add the following lines on the top of
> rte.sdkbuild.mk:
> 
> 	ifdef T
> 	ifeq ("$(origin T)", "command line")
> 	$(error "Cannot use T= with a build/clean target")
> 	endif
> 	endif
> 
> 
> It would then display the proper error message.
> Can you have a try?

You're right. It was not clear to me that T= is coinceived as option of the "config" target only, but it makes absolutely sense.
I added the code you posted on ret.sdkbuild.mk and it works just fine, making this usage case more clear... I just submitted a patch for that.

Thanks,
Francesco



More information about the dev mailing list