[dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop

Lu, Wenzhuo wenzhuo.lu at intel.com
Fri Apr 15 03:31:03 CEST 2016


Hi,

> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Piotr Azarewicz
> Sent: Thursday, April 14, 2016 6:00 PM
> To: Zhang, Helin; Ananyev, Konstantin
> Cc: dev at dpdk.org; Azarewicz, PiotrX T
> Subject: [dpdk-dev] [PATCH v1 1/1] ixgbe: fix queue stop
> 
> It should be checked if queue enable bit is clear.
> 
> CID 13215 : Wrong operator used (CONSTANT_EXPRESSION_RESULT)
> operator_confusion: txdctl | 33554432 is always 1/true regardless of the values
> of its operand. This occurs as the logical second operand of '&&'.
> 
> CID 13216 : Wrong operator used (CONSTANT_EXPRESSION_RESULT)
> operator_confusion: rxdctl | 33554432 is always 1/true regardless of the values
> of its operand. This occurs as the logical second operand of '&&'.
> 
> Coverity issue: 13215
> Coverity issue: 13216
> Fixes: 029fd06d40fa ("ixgbe: queue start and stop")
> 
> Signed-off-by: Piotr Azarewicz <piotrx.t.azarewicz at intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu at intel.com>
Sometimes machine is smarter than human :)  Thanks Piotr for handling this.


More information about the dev mailing list