[dpdk-dev] [PATCH] eal: fix unchecked return value from library

Stephen Hemminger stephen at networkplumber.org
Thu Apr 21 18:05:46 CEST 2016


On Thu, 21 Apr 2016 13:56:57 +0200
Daniel Mrzyglod <danielx.t.mrzyglod at intel.com> wrote:

> +		if (setsockopt(conn_sock, SOL_SOCKET, SO_LINGER, &l, sizeof(l)) < 0)
> +			RTE_LOG(ERR, EAL, "Cannot set SO_LINGER option "
> +					"on listen socket (%s)\n", strerror(errno));

Priority should be WARNING not ERR because it has no real impact on the application
usability

   level
       This  determines  the  importance  of  the message.  The levels are, in
       order of decreasing importance:

       LOG_EMERG      system is unusable

       LOG_ALERT      action must be taken immediately

       LOG_CRIT       critical conditions

       LOG_ERR        error conditions

       LOG_WARNING    warning conditions

       LOG_NOTICE     normal, but significant, condition

       LOG_INFO       informational message

       LOG_DEBUG      debug-level message



More information about the dev mailing list