[dpdk-dev] [PATCH v6 1/8] qede: Add maintainers, documentation and license

Bruce Richardson bruce.richardson at intel.com
Tue Apr 26 17:04:23 CEST 2016


On Mon, Apr 25, 2016 at 10:12:59PM -0700, Rasesh Mody wrote:
> Signed-off-by: Harish Patil <harish.patil at qlogic.com>
> Signed-off-by: Rasesh Mody <rasesh.mody at qlogic.com>
> Signed-off-by: Sony Chacko <sony.chacko at qlogic.com>
> ---
>  MAINTAINERS                       |    7 +
>  doc/guides/nics/index.rst         |    1 +
>  doc/guides/nics/overview.rst      |   86 +++++-----
>  doc/guides/nics/qede.rst          |  314 +++++++++++++++++++++++++++++++++++++
>  drivers/net/qede/LICENSE.qede_pmd |   28 ++++
>  5 files changed, 393 insertions(+), 43 deletions(-)
>  create mode 100644 doc/guides/nics/qede.rst
>  create mode 100644 drivers/net/qede/LICENSE.qede_pmd
> 
Hi,

While it's great to see the documentation for each driver coming in the same
patchset as the driver itself, can you perhaps see about merging some of the doc
changes here in with the other patches. For example, the license and maintainers
changes can probably go with the base code drop, while the NIC overview
documentation should go with the core code for the driver. 

Ideally, the feature matrix would be updated as each patch adds new features,
but since this is a new driver, I'm ok with just having this as part of that
core driver patch too - with a note in the commit stating that the following
commits contain the code for the features not implemented in that one.

Thomas, John McNamara, as keen viewers and maintainers of our documentation,
any comments or strong objection to this?

Regards,
/Bruce


More information about the dev mailing list