[dpdk-dev] [PATCH 0/7] vhost/example cleanup/fix

Yuanhan Liu yuanhan.liu at linux.intel.com
Thu Apr 28 08:09:02 CEST 2016


On Thu, Apr 28, 2016 at 05:45:16AM +0000, Wang, Zhihong wrote:
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Yuanhan Liu
> > Sent: Tuesday, April 26, 2016 12:46 PM
> > To: dev at dpdk.org
> > Cc: Xie, Huawei <huawei.xie at intel.com>; Yuanhan Liu
> > <yuanhan.liu at linux.intel.com>
> > Subject: [dpdk-dev] [PATCH 0/7] vhost/example cleanup/fix
> > 
> > I'm starting to work on the vhost ABI refactoring, that I also have to
> > touch the vhost example code, to make it work. The vhost example code,
> > however, is very messy, full of __very__ long lines. This would make
> > a later diff to apply the new vhost API be very ugly, therefore, not
> > friendly for review. This is how this cleanup comes.
> 
> 
> I think this patch is great effort to clean the messy code and make clearer
> logic, only one suggestion: do you think a complete cleanup would help more?

Yes, but I will stop here, and maybe do the left in near future, as I
have more important thing to do now. I even thought about to make the
VMDq and VLAN stuff optional, to not let our example connect with those
hardware feature that tight.

So, feel free to make patches to clean it further if you have time.

	--yliu


More information about the dev mailing list