[dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for better scatter-gather tests

[De Lara Guarch, Pablo]

> -----Original Message-----
> From: Maciej Czekaj [mailto:maciej.czekaj at caviumnetworks.com]
> Sent: Thursday, April 28, 2016 1:10 PM
> To: De Lara Guarch, Pablo; dev at dpdk.org
> Cc: Mcnamara, John
> Subject: Re: [dpdk-dev] [PATCH v2 0/3] testpmd: extend commands for
> better scatter-gather tests
> 
> On Thu, 28 Apr 2016 08:52:59 +0000 De Lara Guarch, Pablo wrote:
> >
> >
> >> -----Original Message-----
> >> From: maciej.czekaj at caviumnetworks.com
> >> [mailto:maciej.czekaj at caviumnetworks.com]
> >> Sent: Friday, April 22, 2016 3:51 PM
> >> To: dev at dpdk.org
> >> Cc: De Lara Guarch, Pablo; Mcnamara, John; Maciej Czekaj
> >> Subject: [PATCH v2 0/3] testpmd: extend commands for better scatter-
> gather
> >> tests
> >>
> >> From: Maciej Czekaj <maciej.czekaj at caviumnetworks.com>
> >>
> >> v2:
> >>   - included documentation changes
> >>   - added value check for "port config all txqflags" as in --tqxflags
> paramater
> >>
> >> Maciej Czekaj (3):
> >>    app/testpmd: add "enable-scatter" parameter
> >>    app/testpmd: extend port config with scatter parameter
> >>    app/testpmd: support setting up txq_flags value in command line
> >>
> >>   app/test-pmd/cmdline.c                      | 86
> +++++++++++++++++++++++++++--
> >>   app/test-pmd/parameters.c                   |  3 +
> >>   doc/guides/testpmd_app_ug/run_app.rst       |  4 ++
> >>   doc/guides/testpmd_app_ug/testpmd_funcs.rst | 20 +++++++
> >>   4 files changed, 109 insertions(+), 4 deletions(-)
> >>
> >> --
> >> 1.9.1
> >
> > Series-acked-by: Pablo de Lara <pablo.de.lara.guarch at intel.com>
> >
> > Just one comment, maybe we should include some extra info in "show port
> info all", like txqflags or scatter mode.
> >
> 
> txqflags is displayed in:
>   - a forwarding info upon start command
>   - show txq info
> 
> scatter mode is displayed in:
>   - show rxq info
> 
> Still I think it is a good point to aggregate it in port info.
> 
> I will address it in v3.

Oh, true, good point. Then, probably not necessary, as we would be duplicating  information.