[dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue
Wang, Zhihong
zhihong.wang at intel.com
Wed Aug 24 05:37:03 CEST 2016
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Monday, August 22, 2016 6:35 PM
> To: Maxime Coquelin <maxime.coquelin at redhat.com>; Wang, Zhihong
> <zhihong.wang at intel.com>; yuanhan.liu at linux.intel.com
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3 0/5] vhost: optimize enqueue
>
> 2016-08-22 12:01, Maxime Coquelin:
> > I forgot to add that before this series, I think we should first fix the
> windows bug.
> > Else we will need a dedicated fix for the stable branch.
>
> This is a funny situation :)
> If Zhihong had reworked the code without mentioning it is fixing a scenario
> with Windows guests, maybe that nobody would have notice ;) That's
> probably why it is not written in v2/v3. But thanks to the v1, we all know it:
> "It also fixes the issue working with Windows VMs."
I thought it'd be more appropriate to send a dedicated fix for stable branch.
So I removed this info.
>
> So yes, it would be a lot better to find the root cause and try to have a
> minimal fix for 16.07, then rework the code for performance in 16.11.
> I think we must avoid silent fixes, and even more, avoid writing specific fixes
> for stable branches without validating them in the master branch and its large
> users base.
Okay, that's also what Maxime and Yuanhan suggest.
BTW the root cause has been identified and fix will be in v4.
>
> Thanks for your good works guys, DPDK vhost is improving very well.
More information about the dev
mailing list