[dpdk-dev] [PATCH v5 19/29] app/testpmd: use unicast promiscuous mode on i40e

Ferruh Yigit ferruh.yigit at intel.com
Mon Dec 19 12:05:29 CET 2016


On 12/16/2016 8:28 PM, Vincent JARDIN wrote:
> Le 16/12/2016 à 20:02, Ferruh Yigit a écrit :
>> +#ifdef RTE_LIBRTE_I40E_PMD
>> +	ret = rte_pmd_i40e_set_vf_unicast_promisc(res->port_id,
>> +			res->vf_id, is_on);
>> +#endif
> 
> Why is an ifdef used here? It won't scale to all PMDs.

As explained in previous e-mail, because these are PMD specific APIs.
And it is not expected to scale to all PMDs.

> 
> I means that you are missing an abstraction layer.
> 

Yes, intentionally.


More information about the dev mailing list