[dpdk-dev] Example(Load_balancer) Tx Flush Bug(This bug DPDK each version)

Thomas Monjalon thomas.monjalon at 6wind.com
Wed Dec 21 16:08:47 CET 2016


Hi,

Thanks for trying to send a patch.
Below are some comments to help you sending a proper patch.

2016-12-21 22:39, Maple:
> From 94f2eaed51e6e5402e8c03b80e0999a4fd420390 Mon Sep 17 00:00:00 2001
> From: root <root at liujian@raisecom.com>

Here we should have your real name, not "root".

> To: <dev at dpdk.org>
> Cc: <thomas.monjalon at 6wind.com>, <lifei at raisecom.com>,<shizhan at raisecom.com>
> Date: Wed, 21 Dec 2016 22:31:29 +0800
> Subject: [PATCH] load_balancer Tx Flush Bug
> 
> We found a bug in use load_balancer example,and,This bug DPDK each version.
> In IO tx flush, only flush port 0.
> So,If I enable more than the Port,then,In addition to 0 port won't flush.
> 
> Signed-off-by: root <root at liujian@raisecom.com>

Here alse we should have your real name.
See ~/.gitconfig

> ---
>  a/examples/load_balancer/runtime.c | 667 ++++++++++++++++++++++++++++++++++++
>  b/examples/load_balancer/runtime.c | 669 +++++++++++++++++++++++++++++++++++++

You are sending the whole file instead of the diff.
Are you using git?
It should be as simple as "git clone git://dpdk.org/dpdk", then
modify the file, then "git commit -as", then send patch with
"git send-email -1 --to dev at dpdk.org".
As it will be your second version, you should add these options:
-v2 --in-reply-to '<2016122122394164225248 at raisecom.com>'

Thanks


More information about the dev mailing list