[dpdk-dev] [PATCH v3] testpmd: fix wrong prompt in tx_vlan set command handler

Bruce Richardson bruce.richardson at intel.com
Thu Feb 4 10:52:54 CET 2016


On Thu, Feb 04, 2016 at 04:27:32PM +0800, Wang Xiao W wrote:
> When using testpmd, sometimes we forget the right order of port_id and
> vid in "tx_vlan set (port_id) vlan_id[, vlan_id_outer]\n" command, and
> input "tx_vlan set 51 0", we'll get a strange prompt saying "Error, as
> QinQ has been enabled.".
> 
> In cmd_tx_vlan_set_parsed function, the first thing we do is checking
> the port's vlan_offload capability, rather than checking validity of the
> port_id, therefore if it's an invalid port_id we'll get the above wrong
> message. We should always make sure that we get a valid port_id before
> we do other things.
> 
> It's the similar issue for cmd_tx_vlan_set_qinq_parsed function.
> 
> Signed-off-by: Wang Xiao W <xiao.w.wang at intel.com>

Please include a fixes line, in patches fixing problems.
thanks,
/Bruce




More information about the dev mailing list