[dpdk-dev] [PATCH] eal/x86: Fix build with clang for old AVX

Thomas Monjalon thomas.monjalon at 6wind.com
Thu Feb 4 22:32:23 CET 2016


2016-02-03 21:12, Zhihong Wang:
> When configuring RTE_MACHINE to "default", rte_memcpy implementation
> is the default one (old AVX).
> In this code, clang raises a warning thanks to -Wsometimes-uninitialized:
> 
> rte_memcpy.h:838:6: error:
> variable 'srcofs' is used uninitialized whenever 'if' condition is false
>         if (dstofss > 0) {
>             ^~~~~~~~~~~
> rte_memcpy.h:849:6: note: uninitialized use occurs here
>         if (srcofs == 0) {
>             ^~~~~~
> 
> It is fixed by moving srcofs initialization out of the condition.
> Also dstofss calculation is corrected.
> 
> Fixes: 1ae817f9f887 ("eal/x86: tune memcpy for platforms without AVX512")
> 
> Signed-off-by: Zhihong Wang <zhihong.wang at intel.com>
> Reported-by: De Lara Guarch, Pablo <pablo.de.lara.guarch at intel.com>

Applied, thanks


More information about the dev mailing list