[dpdk-dev] [PATCH v3 1/2] version: switch to year/month version numbers

[Mcnamara, John]

> -----Original Message-----
> From: Mcnamara, John
> Sent: Wednesday, February 10, 2016 5:02 PM
> To: dev at dpdk.org
> Cc: thomas.monjalon at 6wind.com; Richardson, Bruce
> <bruce.richardson at intel.com>; Mcnamara, John <john.mcnamara at intel.com>
> Subject: [PATCH v3 1/2] version: switch to year/month version numbers


> diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index
> ffa5730..fd4dd39 100644
> --- a/drivers/net/nfp/nfp_net.c
> +++ b/drivers/net/nfp/nfp_net.c
> @@ -1070,9 +1070,7 @@ nfp_net_infos_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
>  	};
> 
>  	dev_info->reta_size = NFP_NET_CFG_RSS_ITBL_SZ; 
>-#if RTE_VER_MAJOR == 2 && RTE_VER_MINOR >= 1
>  	dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
>-#endif  }
> 

Hi Alejandro,

Please note the above change to the nfp_net.c code due to the name change
in the version macro names.


I was originally going to change it to this:

    #if RTE_VER_YEAR == 2 && RTE_VER_MONTH >= 1
        dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
    #endif

Or better:

    #if RTE_VERSION >= 0x02010000
        dev_info->hash_key_size = NFP_NET_CFG_RSS_KEY_SZ;
    #endif

However, since the code was added in DPDK 2.2 the version check doesn't seem
necessary, so I removed it. If you need it back in for some reason let me know.

John