[dpdk-dev] thoughts on DPDK after a few days of reading sources

Christian Ehrhardt christian.ehrhardt at canonical.com
Mon Feb 15 11:36:49 CET 2016


On Thu, Feb 11, 2016 at 8:58 AM, Thomas Monjalon <thomas.monjalon at 6wind.com>
wrote:

> Hi,
>
> 2016-02-10 19:05, Seth Arnold:
> > I've taken some notes while reading the sources; I'm sharing them in the
> > hopes that it's useful: on the one hand my fresh eyes may spot things
> that
> > you've overlooked, on the other hand your familiarity with the code means
> > that you're better suited to judge what I've found.
>
> Thanks for taking time and sharing, it's very valuable.
>
> > - shellcheck reports extensive cases of forgotten quotes to prevent word
> >   splitting or globbing, potentially unused variables, error-prone printf
> >   formatting. The scripts that are going to be used at runtime should be
> >   fixed:
> >   - ./debian/dpdk-init
> >   - ./debian/dpdk.init
>
> These files are not in the tree. Should they?
>
>
You are right, they are not in tree.
These few are parts of the ubuntu packaging and will be fixed by me this
week.
Sooner or later that might (partially?) flow back to the Debian packaging
that is in tree.


Christian Ehrhardt
Software Engineer, Ubuntu Server
Canonical Ltd

[...]


More information about the dev mailing list