[dpdk-dev] [PATCH 5/6] qede: add driver

Stephen Hemminger stephen at networkplumber.org
Tue Feb 23 06:30:46 CET 2016


On Tue, 23 Feb 2016 02:28:25 +0000
Harish Patil <harish.patil at qlogic.com> wrote:

> All of the checkpatch warnings had been fixed  (except one which cannot be
> fixed) using the checkpatch script available under DPDK scripts/
> directory. The linux checkpatch version is 0.32.
> 
> [root at dut4019 dpdk]# ./scripts/checkpatches.sh patches-send/*.patch
> 
> ### patches-send/0004-qede-add-driver-common-module.patch
> 
> WARNING:CAMELCASE: Avoid CamelCase: <inflateEnd>
> #251: FILE: drivers/net/qede/ecore/bcm_osal.c:120:
> +       inflateEnd(p_hwfn->stream);
> 
> total: 0 errors, 1 warnings, 54467 lines checked
> 
> Wouldn’t that suffice?


The problem is that the DPDK version is shutting off warnings about stuff
that is really incorrect and should be fixed.

Look at the warnings about spaces in strings, I don't know why the DPDK wrapper
disables that.


More information about the dev mailing list