[dpdk-dev] [PATCH v4 09/12] pmd/mlx5: add dev_ptype_info_get implementation

[Tan, Jianfeng]

Hi,

On 2/26/2016 4:26 PM, Adrien Mazarguil wrote:
> Hi Jianfeng,
>
> On Fri, Feb 26, 2016 at 08:09:28AM +0800, Jianfeng Tan wrote:
>> Signed-off-by: Jianfeng Tan <jianfeng.tan at intel.com>
>> ---
>>   drivers/net/mlx4/mlx4.c        |  2 +-
>>   drivers/net/mlx5/mlx5.c        |  1 +
>>   drivers/net/mlx5/mlx5.h        |  1 +
>>   drivers/net/mlx5/mlx5_ethdev.c | 20 ++++++++++++++++++++
>>   drivers/net/mlx5/mlx5_rxtx.c   |  2 ++
>>   5 files changed, 25 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/mlx4/mlx4.c b/drivers/net/mlx4/mlx4.c
>> index 85fdebf..58f4e1a 100644
>> --- a/drivers/net/mlx4/mlx4.c
>> +++ b/drivers/net/mlx4/mlx4.c
>> @@ -4269,7 +4269,7 @@ mlx4_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)
>>   	priv_unlock(priv);
>>   }
>>   
>> -static uint32_t *
>> +static const uint32_t *
>>   mlx4_dev_ptype_info_get(struct rte_eth_dev *dev)
>>   {
>>   	static const uint32_t ptypes[] = {
> I'm probably nitpicking here but this change should be merged in the mlx4
> patch. Otherwise both mlx4 and mlx5 patches look fine to me.
>

Oops, nice catch. It's should be in mlx4 commit. I'll fix it.

Thanks,
Jianfeng