[dpdk-dev] [PATCH v4 3/4] eal: call pci_ioport_map when kernel driver isn't managing the device

David Marchand david.marchand at 6wind.com
Mon Feb 29 10:02:37 CET 2016


On Fri, Feb 26, 2016 at 2:53 AM, Huawei Xie <huawei.xie at intel.com> wrote:
> Call rte_eal_pci_ioport_map only if driver type is RTE_KDRV_NONE, which
> means kernel driver(including UIO/VFIO) isn't managing the device.

I suppose you meant 'Call pci_ioport_map when the pci device is not
bound to a kernel driver'.
If you keep on with your choice of words, at least put a space before the (.


> other minor changes:
>  * use RTE_ARCH_X86 for pci ioport map

This is a trivial change, but this should not be here.

>  * rework rte_eal_pci_ioport_map a bit

Well, not sure this comment helps the review, and anyway, why did you
need to change this ?
Your modification should be the smallest possible.


> Signed-off-by: Huawei Xie <huawei.xie at intel.com>

Let aside these nits.
Acked-by: David Marchand <david.marchand at 6wind.com>


-- 
David Marchand


More information about the dev mailing list