[dpdk-dev] [PATCH] fix checkpatch errors

Yuanhan Liu yuanhan.liu at linux.intel.com
Tue Jan 5 03:27:52 CET 2016


On Tue, Jan 05, 2016 at 02:21:12AM +0000, Tan, Jianfeng wrote:
> 
> 
> > -----Original Message-----
> > From: Xie, Huawei
> > Sent: Monday, January 4, 2016 9:52 AM
> > To: dev at dpdk.org
> > Cc: Mcnamara, John; Tan, Jianfeng; Xie, Huawei
> > Subject: [PATCH] fix checkpatch errors
> > 
> > Signed-off-by: Huawei Xie <huawei.xie at intel.com>
> ...
> >  	mbuf_poolname_build(sock_id, pool_name, sizeof(pool_name));
> > -	return (rte_mempool_lookup((const char *)pool_name));
> > +	return rte_mempool_lookup((const char *)pool_name);
> 
> Hi Huawei,
> 
> Assume this patch is to solve below error (reported by checkpatch):
> ERROR: return is not a function, parentheses are not required
> 
> So maybe above fix is not necessary? Involve more people to discuss.

This fix is good to me.

> And please include the error message in the commit message.

+1

	--yliu


More information about the dev mailing list