[dpdk-dev] [PATCH v4 0/6] vmxnet3 TSO, tx cksum offload and cleanups

Stephen Hemminger stephen at networkplumber.org
Wed Jan 13 05:56:34 CET 2016


On Tue, 12 Jan 2016 18:08:31 -0800
Yong Wang <yongwang at vmware.com> wrote:

> v4:
> * moved cleanups to separate patches
> * correctly handled multi-seg pkts with data ring used
> 
> v3:
> * fixed comments from Stephen
> * added performance number for tx data ring
> 
> v2:
> * fixed some logging issues when debug option turned on
> * updated the txq_flags check in vmxnet3_dev_tx_queue_setup()
> 
> This patchset adds TCP/UDP checksum offload and TSO to vmxnet3 PMD.
> One of the use cases is to support STT.  It also restores the tx
> data ring feature that was removed from a previous patch.
> 
> Yong Wang (6):
>   vmxnet3: fix typos and remove unused struct
>   vmxnet3: restore tx data ring support
>   vmxnet3: cleanup txNumDeferred usage
>   vmxnet3: add tx l4 cksum offload
>   vmxnet3: add TSO support
>   vmxnet3: announce device offload capability
> 
>  doc/guides/rel_notes/release_2_3.rst    |  11 +++
>  drivers/net/vmxnet3/base/includeCheck.h |  39 --------
>  drivers/net/vmxnet3/base/vmxnet3_defs.h |   9 +-
>  drivers/net/vmxnet3/vmxnet3_ethdev.c    |  16 +++-
>  drivers/net/vmxnet3/vmxnet3_ring.h      |  13 ---
>  drivers/net/vmxnet3/vmxnet3_rxtx.c      | 160 +++++++++++++++++++++++++-------
>  6 files changed, 151 insertions(+), 97 deletions(-)
>  delete mode 100644 drivers/net/vmxnet3/base/includeCheck.h
> 

Looks good. The only thing maybe worth adding would be some more checks
int the vmxnet3_dev_configure for unsupported offload bits, etc.

Acked-by: Stephen Hemminger <stephen at networkplumber.org>


More information about the dev mailing list