[dpdk-dev] [dpdk-dev, 2/2] ethdev: move code to common place in hotplug

David Marchand david.marchand at 6wind.com
Fri Jan 22 08:15:05 CET 2016


On Thu, Jan 21, 2016 at 7:42 PM, Thomas Monjalon
<thomas.monjalon at 6wind.com> wrote:
> 2016-01-21 19:06, David Marchand:
>> On Thu, Jan 21, 2016 at 4:38 PM, Jan Viktorin <viktorin at rehivetech.com> wrote:
>> > This change modifies the return value from -EINVAL to -1. I don't know
>> > whether is this an issue but it looks suspicious.
>> Should not be an issue, as the api does not give details on expected
>> negative return values.
>> Just noticed, this also introduces a new log message that was not
>> displayed before.
>> To be safe, I suppose I should restore this.
>> Thomas, opinion ?
> I'm OK with the log message added for this error case.
> I would just keep the -EINVAL return value.

Ok will do.

David Marchand

More information about the dev mailing list