[dpdk-dev] [PATCH 2/3] rte_ctrl_if: add control interface library
konstantin.ananyev at intel.com
Thu Jan 28 14:57:04 CET 2016
> -----Original Message-----
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Thursday, January 28, 2016 1:15 PM
> To: Horton, Remy
> Cc: dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/3] rte_ctrl_if: add control interface library
> On Thu, Jan 28, 2016 at 11:14:47AM +0000, Remy Horton wrote:
> > On 27/01/2016 16:24, Ferruh Yigit wrote:
> > > + default:
> > > + ret = -95 /* EOPNOTSUPP */;
> > > + break;
> > Is this intentional? -EOPNOTSUPP is -122 (-95 is -ENOTSOCK)..
> Return value is not significant, callee just checks for negative value,
> I can remove comment to prevent confusion.
Please use values defined in errno.h, there are plenty of them,
no need to invent your own error codes.
Also pls don't forget to address all comments I gave you offline.
More information about the dev